Due to the current demands:
I propose the following:
It's a good thing to make fast pull requests! If you don't want to merge it (right now): use brackets for commits and PR.
Ex: "Refactoring and Fixing of sixlowpan module" means: "please review, I want this in master" "(Refactoring and Fixing of sixlowpan module)" means: "please review, but this is ongoing work! don't merge it right now"
taken from: https://github.com/RIOT-OS/RIOT/pull/80
What do think?
Best Christian
Hi,
It's a good thing to make fast pull requests! If you don't want to merge it (right now): use brackets for commits and PR.
<snip>
taken from: Refactoring and Fixing of sixlowpan module by miri64 · Pull Request #80 · RIOT-OS/RIOT · GitHub
quote from the same PR by authmillenon: "I've learned that it's best practice to do it this way instead of open an issue and then reference this issue in the closing pull request."
I cannot see any advantage of *not* opening an issue - to the contrary I think it is useful to have a list of solved problems. What the reason behind this idea?
Nevertheless, acknowledging and merging this pull request was probably not very thoroughly thought through on my part.
Cheers, Oleg
Hi,
[…]
taken from: https://github.com/RIOT-OS/RIOT/pull/80 quote from the same PR by authmillenon: “I’ve learned that it’s best practice to do it this way instead of open an issue and then reference this issue in the closing pull request.”
I cannot see any advantage of not opening an issue - to the contrary I think it is useful to have a list of solved problems. What the reason behind this idea?
The idea is that every PR opens a new issue on github, thus having two issues one describing and one solving the problem.
[…]
Cheers, Oleg
Kind regards, Martin