Is it tolerated to create an empty folder to complete a build?

Help
1

Hello,

In PR #21197, we are proposing an Execute In-Place FileSystem (XIPFS) integration for RIOT. We only have DWM1001 boards for development and testing, but this feature should be working for all boards with addressable Flash memory.

Following reviewers advices, code now relies on cpu.h and periph/flashpage.h to retrieve the appropriate Flash defines, when our library is compiled for RIOT.

I then tried to build for nrf52840dk, and the package build failed because of a non-existing path in INCLUDES, namely -I/home/greg/Documents/code/RIOT-Github/build/pkg/xipfs/boards/nrf52840dk.

Given that we want a generic build path to compile XIPFS package for all compliant boards, I found out that creating the missing directory solves the problem. I used RIOTBASE and BOARD variables in the makefile, as follows :

FAKE_FOLDER:=$(RIOTBASE)/build/pkg/xipfs/boards/$(BOARD)
$(shell mkdir -p $(FAKE_FOLDER))

Is this workaround compatible with RIOT build practices, and good enough to go as a fixup for the PR ?

Thanks for reading.

2

Please, ignore my request. The directory was coming from a line in the Makefile.include of our package. It did not ring a bell when I saw it, but was under my eyes all the time though.

My apologies.