updated makefiles & a handler for the heap state shell command (#64)

Updated makefiles allowing a shell working with spaces in paths. And a handler for the heap state shell command.

In sys/shell/commands/sc_heap.c:

> +
> +/**
> + * @file
> + * @internal
> + * @brief	Show the heap state for the LPC2387 on the command shell.
> + *
> + * @author      Freie Universität Berlin, Computer Systems & Telematics
> + * @author	Zakaria Kasmi <zkasmi@inf.fu-berlin.de>
> + *
> + * @note	$Id: sc_heap.c  3854 2013-05-24 17:53:01Z zkasmi $
> + */
> +
> +extern void heap_stats(void);
> +
> +void _heap_handler(char* unnused){
> +	heap_stats();

you are just adding one line of production code. please remove all “windows compat lines” and create one (1) commit and a new pull request.

In sys/shell/commands/sc_heap.c:

> +
> +/**
> + * @file
> + * @internal
> + * @brief	Show the heap state for the LPC2387 on the command shell.
> + *
> + * @author      Freie Universität Berlin, Computer Systems & Telematics
> + * @author	Zakaria Kasmi <zkasmi@inf.fu-berlin.de>
> + *
> + * @note	$Id: sc_heap.c  3854 2013-05-24 17:53:01Z zkasmi $
> + */
> +
> +extern void heap_stats(void);
> +
> +void _heap_handler(char* unnused){
> +	heap_stats();

Ø you are just adding one line of production code one “Line Of Production code” follows the same scheme as in “sc_ps.c”, “sc_id.c.”, etc. — Freie Universität Berlin Institut für Mathematik/Informatik Takustr. 9 14195 Berlin Tel: +49 (0)30 838-75 144 Fax: +49 (0)30 838 75194 http://cst.mi.fu-berlin.de/staff/kasmi.html — Von: Christian Mehlis [mailto:notifications@github.com] Gesendet: Montag, 15. Juli 2013 19:41 An: RIOT-OS/RIOT Cc: Zakaria Kasmi Betreff: Re: [RIOT] updated makefiles & a handler for the heap state shell command (#64) In sys/shell/commands/sc_heap.c:

In sys/shell/commands/sc_heap.c:

> +
> +/**
> + * @file
> + * @internal
> + * @brief	Show the heap state for the LPC2387 on the command shell.
> + *
> + * @author      Freie Universität Berlin, Computer Systems & Telematics
> + * @author	Zakaria Kasmi <zkasmi@inf.fu-berlin.de>
> + *
> + * @note	$Id: sc_heap.c  3854 2013-05-24 17:53:01Z zkasmi $
> + */
> +
> +extern void heap_stats(void);
> +
> +void _heap_handler(char* unnused){
> +	heap_stats();

one “Line Of Production code” follows the same scheme as in “sc_ps.c”, “sc_id.c.”, etc. — Freie Universität Berlin Institut für Mathematik/Informatik Takustr. 9 14195 Berlin Tel: +49 (0)30 838-75 144 Fax: +49 (0)30 838 75194 http://cst.mi.fu-berlin.de/staff/kasmi.html — Von: Christian Mehlis [mailto:notifications@github.com] Gesendet: Montag, 15. Juli 2013 19:41 An: RIOT-OS/RIOT Cc: Zakaria Kasmi Betreff: Re: [RIOT] updated makefiles & a handler for the heap state shell command (#64) In sys/shell/commands/sc_heap.c:

In sys/shell/commands/shell_commands.c:

> @@ -3,22 +3,25 @@
>   *
>   * Copyright (C) 2013  INRIA.
>   *
> - * This file subject to the terms and conditions of the GNU Lesser General
> - * Public License. See the file LICENSE in the top level directory for more
> - * details.
> + * The source code is licensed under the LGPLv2 license, 
> + * see the file LICENSE for more details.

Please keep licence changes seperately.

In sys/shell/commands/shell_commands.c:

>   * @}
>   */
>  
>  #include <shell_commands.h>
>  #include <stdlib.h>
>  
> -extern void _id_handler(char *id);
> +
> +
> +extern void _id_handler(char* id);

Whitespace error?

In sys/shell/commands/sc_heap.c:

> +
> +/**
> + * @file
> + * @internal
> + * @brief	Show the heap state for the LPC2387 on the command shell.
> + *
> + * @author      Freie Universität Berlin, Computer Systems & Telematics
> + * @author	Zakaria Kasmi <zkasmi@inf.fu-berlin.de>
> + *
> + * @note	$Id: sc_heap.c  3854 2013-05-24 17:53:01Z zkasmi $
> + */
> +
> +extern void heap_stats(void);
> +
> +void _heap_handler(char* unnused){
> +	heap_stats();

On 07/16/2013 11:35 AM, Zakaria Kasmi wrote: In sys/shell/commands/sc_heap.c: > +extern void heap_stats(void); > + > +void _heap_handler(char* unnused){ > + heap_stats(); one “Line Of Production code” follows the same scheme as in “sc_ps.c”, “sc_id.c.”, etc. This might be correct, but the commits introducing “sc_ps.c”, “sc_id.c.”, etc. didn’t introduce “Makefile updates”. If we pull your one-liner together with the makefile updates, there’ll be a “merge commit”. Now imagine your one line has a problem somewhere else, and we revert the merge commit. That would also unmerge your Makefile “fixes”. Christian proposed to seperate the makefile fixes from your added functionality.

Agreed!

what is meant by "“windows compat lines”? i find no lines !!!

No sane OS has spaces in it’s path to make, so we were guessing…

It is inconvenient for the Windows-user each time to change $(MAKE) to “$(MAKE)”. Otherwisehttp://www.dict.cc/englisch-deutsch/otherwise.html, the updated makfiles include no windows-specific commands.

The “$(MAKE)” changes might be useful, they just don’t belong in the same pull request as your sc_heap stuff. Thanks for confirming our windows guess.